Re: [RFC][PATCH 5/14] Introduce union stack

On May 19 2007 03:18, Paul Dickson wrote:
>
>How about getting rid of the gotos:
>
>	while (fs) {
>		locked = union_trylock(fs->root);
>		if (locked) {
>			locked = union_trylock(fs->altroot);
>			if (locked) {
>				locked = union_trylock(fs->pwd);
>				if (locked)
>					break;

Suppose we break here...

>				else {
>					union_unlock(fs->altroot);
>					union_unlock(fs->root);
>				}
>			else
>				union_unlock(fs->root);
>			}
>		}
>		read_unlock(&fs->lock);
>		UM_DEBUG_LOCK("Failed to get all semaphores in fs_struct!\n");
>		cpu_relax();
>		read_lock(&fs->lock);
>	}
>	BUG_ON(!fs);

Then no lock is released. Boom.



	Jan
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [RFC][PATCH 0/14] VFS based Union Mount(v1)
    • From: Bharata B Rao <[email protected]>
  • [RFC][PATCH 5/14] Introduce union stack
    • From: Bharata B Rao <[email protected]>
  • Re: [RFC][PATCH 5/14] Introduce union stack
    • From: Badari Pulavarty <[email protected]>
  • Re: [RFC][PATCH 5/14] Introduce union stack
    • From: Paul Dickson <[email protected]>

• Prev by Date: Re: [PATCH] eCryptfs: Delay writing 0's after llseek until write
• Next by Date: Re: [PATCH] ISDN: move card state init to separate function
• Previous by thread: Re: [RFC][PATCH 5/14] Introduce union stack
• Next by thread: Re: [RFC][PATCH 5/14] Introduce union stack
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]