On Tue, May 22, 2007 at 12:42:00AM +0200, Pavel Machek wrote:
> On Mon 2007-05-21 14:45:53, Matthew Garrett wrote:
> > So don't do it badly. The advantage of doing so is that you can make it
> > work properly, which you can't by putting it in the kernel.
>
> You want stuff like critical shutdowns to work even if userspace is
> dead.
I don't think anyone suggested putting the critical shutdown control in
userspace. The kernel already handles that fine.
> I do not think you can control passive cooling adequately from
> userspace, and you can certainly not prevent kernel from slowing
> machine down too soon.
Given the choice between something impossible and something difficult,
I'm inclined towards picking the difficult one.
> Plus, this is actually nasty user-visible change, and a regression
> from 2.6.21. I am not sure why we are even debating this; user-kernel
> interface changed without warning. Patch should be simply reverted.
In http://lkml.org/lkml/2007/1/27/93 you were more than happy to break
an interface even though it could be fixed in a (ugly) way that made it
work again. Here, there's no way to fix this properly - the platform
will quite happily do things based on what it believes the trip points
should be, and one of those things may be to alter the trip points.
Imagine the following situation:
1) Platform sets critical shutdown trip point to 85C
2) Userspace sets critical shutdown trip point to 95C
3) Temperature reaches 90C
4) Platform forces reevaluation of trip points
5) Entire invasion fleet is lost
How do you avoid that? Disable the ability for the platform to set trip
points? You're breaking the spec and potentially causing hardware
damage. If you have specific hardware that requires specific spec
breakage, then a better approach would probably be to quirk the kernel
to rectify it. On the other hand, if it works with the Other Leading OS,
we ought to be able to just fix the problem properly.
--
Matthew Garrett | [email protected]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
