Re: [PATCH] Fix UCB1x00 driver to use sched_setscheduler

Hi!

> > > Index: linux-2.6.21-fix-ucb-drivers/drivers/mfd/ucb1x00-ts.c
> > > ===================================================================
> > > --- linux-2.6.21-fix-ucb-drivers.orig/drivers/mfd/ucb1x00-ts.c	2007-05-11 18:53:36.000000000 +0900
> > > +++ linux-2.6.21-fix-ucb-drivers/drivers/mfd/ucb1x00-ts.c	2007-05-11 19:33:20.000000000 +0900
> > > @@ -214,8 +214,9 @@ static int ucb1x00_thread(void *_ts)
> > >  	 * We could run as a real-time thread.  However, thus far
> > >  	 * this doesn't seem to be necessary.
> > >  	 */
> > > -//	tsk->policy = SCHED_FIFO;
> > > -//	tsk->rt_priority = 1;
> > > +//	struct sched_param param = { .sched_priority = 1 };
> > > +//
> > > +//	sched_setscheduler(tsk, SCHED_FIFO, &param);
> > 
> > Can we please remove the unused code completely instead of replacing it
> > by more commented out code ?
> 
> It's OK to me, but I'm not the driver writer and doesn't know how important
> are those comments. If removing them is better for driver writers too, here
> is the patch.

I doubt anyone cares either way. Feel free to add my ACK to either
"remove" or "fix" version.
								Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] Fix UCB1x00 driver to use sched_setscheduler
    • From: Satoru Takeuchi <[email protected]>
  • Re: [PATCH] Fix UCB1x00 driver to use sched_setscheduler
    • From: Thomas Gleixner <[email protected]>
  • Re: [PATCH] Fix UCB1x00 driver to use sched_setscheduler
    • From: Satoru Takeuchi <[email protected]>

• Prev by Date: [PATCH 5/5] Use mutex instead of semaphore in the MTD DataFlash driver
• Next by Date: [patch] simplify compat_sys_timerfd.
• Previous by thread: Re: [PATCH] Fix UCB1x00 driver to use sched_setscheduler
• Next by thread: [patch] Refine SCREEN_INFO sanity check for vgacon initialization.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]