Re: [patch 3/3] clockevents: Fix resume logic - updated version

On Sat, 2007-05-12 at 09:51 -0700, Andrew Morton wrote:
> The locking in clocksource_resume_watchdog looks pretty pointless anyway.
> Can't we just delete it?
> 
> The only thing it can race against is, conceivably,
> 
>         resumed = watchdog_resumed;
>         if (unlikely(resumed))
>                 watchdog_resumed = 0;
> 
> which could be solved by using test_and_clear_bit().

True. I'll redo it.

> Does anyone have any theories about my lockdep warning?

Can you upload a snapshot of your current queue ?

	tglx



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [patch 3/3] clockevents: Fix resume logic - updated version
    • From: Thomas Gleixner <[email protected]>
  • Re: [patch 3/3] clockevents: Fix resume logic - updated version
    • From: Andrew Morton <[email protected]>

• References:
  • Re: [patch 3/3] clockevents: Fix resume logic - updated version
    • From: Andrew Morton <[email protected]>
  • Re: [patch 3/3] clockevents: Fix resume logic - updated version
    • From: "Rafael J. Wysocki" <[email protected]>
  • Re: [patch 3/3] clockevents: Fix resume logic - updated version
    • From: "Rafael J. Wysocki" <[email protected]>
  • Re: [patch 3/3] clockevents: Fix resume logic - updated version
    • From: Andrew Morton <[email protected]>
  • Re: [patch 3/3] clockevents: Fix resume logic - updated version
    • From: Thomas Gleixner <[email protected]>
  • Re: [patch 3/3] clockevents: Fix resume logic - updated version
    • From: Andrew Morton <[email protected]>
  • Re: [patch 3/3] clockevents: Fix resume logic - updated version
    • From: Thomas Gleixner <[email protected]>
  • Re: [patch 3/3] clockevents: Fix resume logic - updated version
    • From: Andrew Morton <[email protected]>
  • Re: [patch 3/3] clockevents: Fix resume logic - updated version
    • From: Thomas Gleixner <[email protected]>
  • Re: [patch 3/3] clockevents: Fix resume logic - updated version
    • From: Andrew Morton <[email protected]>

• Prev by Date: Re: [patch 3/3] clockevents: Fix resume logic - updated version
• Next by Date: Re: [PATCH 1/7] Freezer: Read PF_BORROWED_MM in a nonracy way
• Previous by thread: Re: [patch 3/3] clockevents: Fix resume logic - updated version
• Next by thread: Re: [patch 3/3] clockevents: Fix resume logic - updated version
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]