Re: [patch 7/7] tidy up usermode helper waiting a bit

[/me wonders why he was CC'ed]

>  	/* CLONE_VFORK: wait until the usermode helper has execve'd
>  	 * successfully We need the data structures to stay around
>  	 * until that is done.  */
> -	if (wait)
> +	if (wait == UMH_WAIT_PROC)
>  		pid = kernel_thread(wait_for_helper, sub_info,
>  				    CLONE_FS | CLONE_FILES | SIGCHLD);
>  	else
>  		pid = kernel_thread(____call_usermodehelper, sub_info,
>  				    CLONE_VFORK | SIGCHLD);

Isn't that a change in behaviour? Previously it said
	if (wait)
 <=>	if (wait != 0)
 <=>	if (wait != UMH_WAIT_EXEC)
or am I missing something?

johannes

Attachment: signature.asc
Description: This is a digitally signed message part

---

• Follow-Ups:
  • Re: [patch 7/7] tidy up usermode helper waiting a bit
    • From: Jeremy Fitzhardinge <[email protected]>

• References:
  • [patch 0/7] A series of cleanup patches
    • From: Jeremy Fitzhardinge <[email protected]>
  • [patch 7/7] tidy up usermode helper waiting a bit
    • From: Jeremy Fitzhardinge <[email protected]>

• Prev by Date: [PATCH] spelling fixes: arch/sparc/
• Next by Date: [PATCH] spelling fixes: arch/sparc64/
• Previous by thread: [patch 7/7] tidy up usermode helper waiting a bit
• Next by thread: Re: [patch 7/7] tidy up usermode helper waiting a bit
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]