Re: [PATCH] UDF: check for allocated memory for inode data

[Christoph Hellwig - Fri, May 11, 2007 at 11:39:56AM +0100]
| On Fri, May 11, 2007 at 01:01:27PM +0400, Cyrill Gorcunov wrote:
| > [Christoph Hellwig - Fri, May 11, 2007 at 08:29:39AM +0100]
| > 
| > ...
| > 
| > | And please get rid of the UDF_I_* macro for everything you touch, just
| > | put a
| > | 
| > | 	struct udf_inode_info *uip = UDF_I(inode);
| > | 
| > | at the beginning of the function and use the fields directly.
| > | 
| > 
| > Actually to properly remove UDF_I* and UDF_SB_* macroses in the
| > whole UDF subsystem - is _lot_ of work. I'm going to make it but
| > not now (too busy).
| 
| Doing it completely is a lot of work, yes.  I was more thinking of
| converting a piece of code once you do major changes.  But if you
| want to convert all the code as a separate patch I'm more than happy
| aswell.
| 

Christoph, my only argue against getting rid of UDF_I_* macro in
my patch is UDF coding style, I don't want to damage it. I think
we may leave it as is (including my patch). So just review the patch
I sent (second version) and Ack it then so Andrew could include it
into mm tree. Meantime I'm rewritting the whole UDF subsystem to
get rid of that macroses (it will be a long way ;)

		Cyrill

P.S.
But if you still insist on getting rid of UDF_I_ macroses from my patch
just let me now :)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] UDF: check for allocated memory for inode data
    • From: Christoph Hellwig <[email protected]>

• References:
  • [PATCH] UDF: check for allocated memory for inode data
    • From: Cyrill Gorcunov <[email protected]>
  • Re: [PATCH] UDF: check for allocated memory for inode data
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH] UDF: check for allocated memory for inode data
    • From: Christoph Hellwig <[email protected]>
  • Re: [PATCH] UDF: check for allocated memory for inode data
    • From: Cyrill Gorcunov <[email protected]>
  • Re: [PATCH] UDF: check for allocated memory for inode data
    • From: Christoph Hellwig <[email protected]>

• Prev by Date: Re: [patch] CFS scheduler, -v11
• Next by Date: [patch] Refine SCREEN_INFO sanity check for vgacon initialization.
• Previous by thread: Re: [PATCH] UDF: check for allocated memory for inode data
• Next by thread: Re: [PATCH] UDF: check for allocated memory for inode data
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]