On Wed, 9 May 2007, Andrew Morton wrote:
> On Mon, 7 May 2007 14:18:29 -0400 (EDT)
> Scott Murray <[email protected]> wrote:
>
> > On Fri, 4 May 2007, Christoph Hellwig wrote:
> >
> > > On Fri, Apr 27, 2007 at 06:07:49PM -0400, Scott Murray wrote:
> > > > Sorry, it took me a few days to get to testing this out. It looks good,
> > > > but I had to make a couple of tweaks to avoid a hang when rmmod'ing a
> > > > board driver. The board drivers do:
> > > >
> > > > cpci_hp_stop()
> > > > cpci_hp_unregister_controller(controller)
> > > >
> > > > to shutdown, and the check in cpci_hp_unregister_controller if the thread
> > > > is running wasn't working due to a bit too much code being excised. The
> > > > result was kthread_stop being called twice, which hangs. I've indicated
> > > > my changes to avoid this inline below.
> > >
> > > Can you forward the patches with your fix to Andrew to make sure he
> > > picks it up?
> >
> > Andrew, here is my updated version of Christoph's kthread conversion
> > patch for cpci_hotplug. I've CC'ed Kristen so she won't be surprised
> > when this eventually goes to mainline.
>
> A patch in this area would normally go
>
> you->kristen->mainline
> |
> v
> -mm
>
> or
>
> you->kristen->greg->mainline
> |
> v
> -mm
>
> or
>
> you->me->greg->mainline (gets an Acked-by somewhere)
> |
> v
> -mm
>
> or
>
> you->kristen->Len->mainline
> |
> v
> -mm
>
> or something else.
My apologies, it wasn't entirely clear to me that that was happening with
the other kthread conversion patches in the big batch, so I didn't follow
the normal procedure. I'll try to stick to the regular flow up the chain
going forward.
Scott
--
Scott Murray
SOMA Networks, Inc.
Toronto, Ontario
e-mail: [email protected]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
