Re: [PATCH 4/10] ARM: OMAP: gpio init section cleanups

On Sat, May 05, 2007 at 11:04:26AM +0100, Russell King wrote:
> On Mon, Apr 09, 2007 at 05:01:06PM -0400, Tony Lindgren wrote:
> > From: David Brownell <[email protected]>
> > 
> > Minor GPIO cleanups:  remove needless #include, and omap_gpio_init()
> > should be __init, as well as all the board init code calling it.
> > 
> > Signed-off-by: David Brownell <[email protected]>
> > Signed-off-by: Tony Lindgren <[email protected]>
> 
> I've applied 8 patches from this series by cherry picking it from your
> git tree, minus this patch which git wouldn't apply due to fuzz in
> arch/arm/plat-omap/gpio.c.

Incidentally, when doing a build after these patches, I'm seeing:

arch/arm/plat-omap/dma.c: In function `omap_get_dma_src_pos':
arch/arm/plat-omap/dma.c:750: warning: 'offset' might be used uninitialized in this function
arch/arm/plat-omap/dma.c: In function `omap_get_dma_dst_pos':
arch/arm/plat-omap/dma.c:772: warning: 'offset' might be used uninitialized in this function

These look like they're valid warnings to me.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 4/10] ARM: OMAP: gpio init section cleanups
    • From: Tony Lindgren <[email protected]>

• References:
  • [PATCH 0/10] ARM: OMAP: GPIO code updates shared between OMAP1 and OMAP2
    • From: Tony Lindgren <[email protected]>
  • [PATCH 1/10] ARM: OMAP: Enable 24xx GPIO autoidling
    • From: Tony Lindgren <[email protected]>
  • [PATCH 2/10] ARM: OMAP: Implement workaround for GPIO wakeup bug in OMAP2420 silicon
    • From: Tony Lindgren <[email protected]>
  • [PATCH 3/10] ARM: OMAP: /sys/kernel/debug/omap_gpio
    • From: Tony Lindgren <[email protected]>
  • [PATCH 4/10] ARM: OMAP: gpio init section cleanups
    • From: Tony Lindgren <[email protected]>
  • Re: [PATCH 4/10] ARM: OMAP: gpio init section cleanups
    • From: Russell King <[email protected]>

• Prev by Date: [PATCH] lguest: don't use paravirt_probe, it's dying
• Next by Date: Re: [RFC 2/3] SLUB: Implement targeted reclaim and partial list defragmentation
• Previous by thread: Re: [PATCH 4/10] ARM: OMAP: gpio init section cleanups
• Next by thread: Re: [PATCH 4/10] ARM: OMAP: gpio init section cleanups
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]