Re: [PATCH] [24/30] x86_64: Shut up warnings for vfat compat ioctls on other file systems

On Tuesday 01 May 2007 17:45:52 Chuck Ebbert wrote:
> Andi Kleen wrote:
> > vfat implements compat handlers for these ioctls, but when they
> > were executed on other file systems the kernel would still complain
> > about an unknown compat ioctl.  Just declare them as compatible
> > and let them be rejected when not needed by the normal path.
> > 
> > This makes wine runs a lot quieter
> 
> Does this also restore the original -ENOTTY return code?
> 
> The change that made it return -EINVAL broke a few Wine apps.

No it's still EINVAL as before. I just eliminated the printks.

I guess one could add a IGNORE_IOCTL_ENOTTY() or somesuch though if it's 
really a problem.

-Andi

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

References:
- [PATCH] [0/30] x86 candidate patches for review VII: VDSO, CPUID, NMI watchdog, MCE, misc
  - From: Andi Kleen <[email protected]>
- [PATCH] [24/30] x86_64: Shut up warnings for vfat compat ioctls on other file systems
  - From: Andi Kleen <[email protected]>
- Re: [PATCH] [24/30] x86_64: Shut up warnings for vfat compat ioctls on other file systems
  - From: Chuck Ebbert <[email protected]>

Prev by Date: Re: [patch 20/38] Minor fault path optimization.
Next by Date: Re: [patch 20/38] Minor fault path optimization.
Previous by thread: Re: [PATCH] [24/30] x86_64: Shut up warnings for vfat compat ioctls on other file systems
Next by thread: [PATCH] [4/30] x86_64: Use the 32bit wd_ops for 64bit too.
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]