Re: [PATCH -mm] workqueue: debug possible endless loop in cancel_rearming_delayed_work

On Thu, Apr 19, 2007 at 09:32:22AM +0200, Ingo Molnar wrote:
> 
> * Jarek Poplawski <[email protected]> wrote:
> 
> > +		int i = 1000;
> >  
> > -		while (!cancel_delayed_work(dwork))
> > +		while (!cancel_delayed_work(dwork)) {
> >  			flush_workqueue(wq);
> > +			BUG_ON(!i--);
> > +		}
> 
> if then make it a WARN_ON(). But ... dont we have the softlockup 
> detector for such cases? Does CONFIG_DETECT_SOFTLOCKUP=y give you enough 
> information?

No, you won't get a soft lockup - flush_workqueue() has a 
schedule() call in the middle of it.

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH -mm] workqueue: debug possible endless loop in cancel_rearming_delayed_work
    • From: Jarek Poplawski <[email protected]>
  • Re: [PATCH -mm] workqueue: debug possible endless loop in cancel_rearming_delayed_work
    • From: Ingo Molnar <[email protected]>

• Prev by Date: Re: [PATCH -mm] workqueue: debug possible endless loop in cancel_rearming_delayed_work
• Next by Date: Re: Bitbanging i2c bus driver using the GPIO API
• Previous by thread: Re: [PATCH -mm] workqueue: debug possible endless loop in cancel_rearming_delayed_work
• Next by thread: Re: [PATCH -mm] workqueue: debug possible endless loop in cancel_rearming_delayed_work
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]