Re: [NETLINK] Don't attach callback to a going-away netlink socket

Evgeniy Polyakov wrote:
> On Wed, Apr 18, 2007 at 10:50:42AM +0200, Patrick McHardy ([email protected]) wrote:
> 
>>>I thought that with releasing a socket, which will have a callback
>>>attached only results in a leak of the callback? In that case we can
>>>just free it in dump() just like it is done in no-error path already.
>>>Or do I miss something additional?
>>
>>That would only work if there is nothing to dump (cb->dump returns 0).
>>Otherwise it is not freed.
> 
> 
> That is what I referred to as error path. Btw, with positive return
> value we end up in subsequent call to input which will free callback
> under lock as expected.


No, nothing is going to call netlink_dump after the initial call since
the socket is gone.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [NETLINK] Don't attach callback to a going-away netlink socket
    • From: Evgeniy Polyakov <[email protected]>

• References:
  • [NETLINK] Don't attach callback to a going-away netlink socket
    • From: Pavel Emelianov <[email protected]>
  • Re: [NETLINK] Don't attach callback to a going-away netlink socket
    • From: Evgeniy Polyakov <[email protected]>
  • Re: [NETLINK] Don't attach callback to a going-away netlink socket
    • From: Patrick McHardy <[email protected]>
  • Re: [NETLINK] Don't attach callback to a going-away netlink socket
    • From: Evgeniy Polyakov <[email protected]>
  • Re: [NETLINK] Don't attach callback to a going-away netlink socket
    • From: Patrick McHardy <[email protected]>
  • Re: [NETLINK] Don't attach callback to a going-away netlink socket
    • From: Evgeniy Polyakov <[email protected]>

• Prev by Date: Re: [NETLINK] Don't attach callback to a going-away netlink socket
• Next by Date: Re: [PATCH] Provide better abstraction for the serial drivers to xmit buf and tty
• Previous by thread: Re: [NETLINK] Don't attach callback to a going-away netlink socket
• Next by thread: Re: [NETLINK] Don't attach callback to a going-away netlink socket
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]