Re: [NETLINK] Don't attach callback to a going-away netlink socket

On Wed, Apr 18, 2007 at 12:32:40PM +0400, Pavel Emelianov ([email protected]) wrote:
> Evgeniy Polyakov wrote:
> > On Wed, Apr 18, 2007 at 12:16:18PM +0400, Pavel Emelianov ([email protected]) wrote:
> >> Sorry, I forgot to put netdev and David in Cc when I first sent it.
> >>
> >> There is a race between netlink_dump_start() and netlink_release()
> >> that can lead to the situation when a netlink socket with non-zero
> >> callback is freed.
> > 
> > Out of curiosity, why not to fix a netlink_dump_start() to remove
> > callback in error path, since in 'no-error' path it removes it in
> 
> Error path is not relevant here. The problem is that we
> keep a calback on a socket that is about to be freed.

Yes, you are right, that it will not be freed in netlink_release(), 
but it will be freed in netlink_dump() after it is processed (in no-error 
path only though).

-- 
	Evgeniy Polyakov
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [NETLINK] Don't attach callback to a going-away netlink socket
    • From: Pavel Emelianov <[email protected]>

• References:
  • [NETLINK] Don't attach callback to a going-away netlink socket
    • From: Pavel Emelianov <[email protected]>
  • Re: [NETLINK] Don't attach callback to a going-away netlink socket
    • From: Evgeniy Polyakov <[email protected]>
  • Re: [NETLINK] Don't attach callback to a going-away netlink socket
    • From: Pavel Emelianov <[email protected]>

• Prev by Date: Re: [NETLINK] Don't attach callback to a going-away netlink socket
• Next by Date: Re: [PATCH RFD] alternative kobject release wait mechanism
• Previous by thread: Re: [NETLINK] Don't attach callback to a going-away netlink socket
• Next by thread: Re: [NETLINK] Don't attach callback to a going-away netlink socket
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]