RE: [PATCH] NET: [UPDATED] Multiqueue network device support implementation.

> >>>+			skb->queue_mapping =
> >>>+				 
> q->prio2band[q->band2queue[band&TC_PRIO_MAX]];
> >>
> >>
> >>Does this needs to be cleared at some point again? TC actions might 
> >>redirect or mirror packets to other (multiqueue) devices.
> > 
> > 
> > If an skb is redirected to another device, the skb should 
> be filtered 
> > through that device's qdisc, yes?
> 
> 
> Yes, but the device might not have a queue or use something 
> different than prio, so the value would stay the same. I 
> think you need to clear it before enqueueing a packet or 
> alternatively when redirecting in the mirred action.
> 

I see what you're saying now - I'll set the queue_mapping to zero before
the enqueue occurs.  Thanks for the feedback.

-PJ Waskiewicz
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • Re: [PATCH] NET: [UPDATED] Multiqueue network device support implementation.
    • From: Patrick McHardy <[email protected]>

• Prev by Date: Re: [KJ][PATCH] SPIN_LOCK_UNLOCKED cleanup in drivers/ata/pata_winbond.c
• Next by Date: Re: [PATCH] [KERNEL-DOC] alphabetically-sorted entries in index.html of 'htmldocs'
• Previous by thread: Re: [PATCH] NET: [UPDATED] Multiqueue network device support implementation.
• Next by thread: Re: Preemption Broken: centrino_target busted under SMP on 2.6.20.4
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]