[2.6 patch] kconfig: abort configuration with recursive dependencies

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



A recursive kconfig dependency is a bug that has to be fixed, and that 
might currently not be noted until booting the built kernel.

Currently, the warning that a recursive dependency was detected scrolls 
away during "make oldconfig", and often people don't notice until they 
booted the kernel and note something like "Why is there no IPV6 support?".

This patch therefore lets the configuration fail if kconfig found a 
recursive dependency.

Signed-off-by: Adrian Bunk <[email protected]>

--- linux-2.6.20-mm2/scripts/kconfig/symbol.c.old	2007-02-25 19:27:07.000000000 +0100
+++ linux-2.6.20-mm2/scripts/kconfig/symbol.c	2007-02-25 19:30:32.000000000 +0100
@@ -792,7 +792,7 @@
 	struct property *prop;
 
 	if (sym->flags & SYMBOL_CHECK) {
-		printf("Warning! Found recursive dependency: %s", sym->name);
+		printf("Error: Found recursive dependency: %s", sym->name);
 		return sym;
 	}
 	if (sym->flags & SYMBOL_CHECKED)
@@ -820,7 +820,7 @@
 		printf(" %s", sym->name);
 		if (sym2 == sym) {
 			printf("\n");
-			sym2 = NULL;
+			exit(1);
 		}
 	}
 	sym->flags &= ~SYMBOL_CHECK;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux