Re: [PATCH] mm/mincore: Return EFAULT when passed an invalid address.

On Fri, 23 Feb 2007, Joel Becker wrote:

>  	The locking fix to sys_mincore in commit
> 2f77d107050abc14bc393b34bdb7b91cf670c250 returns -ENOMEM when given a
> bad userspace address.  It should return -EFAULT.

No, I think you're getting confused by the way Linus uses access_ok
on the address range given with the access_ok on the vector address.

Before and after, an access_ok failure on the output vector address
gives -EFAULT.  Before and after, an invalid address in the range
to be inspected gives -ENOMEM.

Which is consistent with the other m* system calls: -EFAULT if
arguments are inaccessible, -ENOMEM if address range is invalid.

Hugh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] mm/mincore: Return EFAULT when passed an invalid address.
    • From: Joel Becker <[email protected]>

• References:
  • mincore returning -ENOMEM instead of -EFAULT
    • From: Joel Becker <[email protected]>
  • [PATCH] mm/mincore: Return EFAULT when passed an invalid address.
    • From: Joel Becker <[email protected]>

• Prev by Date: Re: I2O block driver broken in kernel 2.6.19?
• Next by Date: [RFC] div64_64 support
• Previous by thread: [PATCH] mm/mincore: Return EFAULT when passed an invalid address.
• Next by thread: Re: [PATCH] mm/mincore: Return EFAULT when passed an invalid address.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]