Re: [Patch 2/2] cciss: add shutdown support (replaces reboot notifier)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 22, 2007 at 03:49:38PM -0600, James Bottomley wrote:
> On Thu, 2007-02-22 at 15:38 -0600, Mike Miller (OS Dev) wrote:
> >         .remove = __devexit_p(cciss_remove_one),
> >         .id_table = cciss_pci_device_id,        /* id_table */
> > +       .shutdown = cciss_remove_one,
> 
> You need a __devexit_p() wrapper for this one too.

No.  We want to call this even in the non-modular, non-hotplug
case.  So we should remove __devexit from cciss_remove_one.  Or
alternatively implement a separate cciss_shutdown that just does
the nessecary cache flushing, like most other drivers do.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux