Re: [PATCH] update ctime and mtime for mmaped write

> > This flag is checked in msync() and __fput(), and if set, the file
> > times are updated and the flag is cleared
> 
> Why not also check inside vfs_getattr?

This is the minimum, that the standard asks for.

Note, your porposal would touch the times in vfs_getattr(), which
means, that the modification times would depend on the time of the
last stat() call, which is not really right, though it would still be
conforming.

It is much saner, if the modification time is always the time of the
last write() or msync().

Miklos
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] update ctime and mtime for mmaped write
    • From: Trond Myklebust <[email protected]>

• References:
  • [PATCH] update ctime and mtime for mmaped write
    • From: Miklos Szeredi <[email protected]>
  • Re: [PATCH] update ctime and mtime for mmaped write
    • From: Trond Myklebust <[email protected]>

• Prev by Date: Re: [PATCH] slab: ensure cache_alloc_refill terminates
• Next by Date: Re: [stable] [patch 00/18] 2.6.18-stable review
• Previous by thread: Re: [PATCH] update ctime and mtime for mmaped write
• Next by thread: Re: [PATCH] update ctime and mtime for mmaped write
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]