Re: [PATCH] fix refrigerator() vs thaw_process() race

Hi!

> refrigerator() can miss a wakeup, "wait event" loop needs a proper memory
> ordering.
> 
> Signed-off-by: Oleg Nesterov <[email protected]>
> 
> --- WQ/kernel/power/process.c~WAKE	2007-02-18 22:56:49.000000000 +0300
> +++ WQ/kernel/power/process.c	2007-02-19 01:04:26.000000000 +0300
> @@ -46,8 +46,10 @@ void refrigerator(void)
>  	recalc_sigpending(); /* We sent fake signal, clean it up */
>  	spin_unlock_irq(&current->sighand->siglock);
>  
> -		current->state = TASK_UNINTERRUPTIBLE;
> +		set_current_state(TASK_UNINTERRUPTIBLE);


Looks okay to me... but this one liner would be exactly as effective,
right?

								Pavel

>  		schedule();
>  	}
>  	pr_debug("%s left refrigerator\n", current->comm);

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] fix refrigerator() vs thaw_process() race
    • From: Oleg Nesterov <[email protected]>

• References:
  • [PATCH] fix refrigerator() vs thaw_process() race
    • From: Oleg Nesterov <[email protected]>

• Prev by Date: Re: [PATCH 00/44 take 2] [UBI] Unsorted Block Images
• Next by Date: Re: [RFC][PATCH][3/4] Add reclaim support
• Previous by thread: Re: [PATCH] fix refrigerator() vs thaw_process() race
• Next by thread: Re: [PATCH] fix refrigerator() vs thaw_process() race
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]