Re: sparse chokes on arch/i386/kernel/i8253.c (was: 2.6.20-mm1)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Andrew Morton ([email protected]) wrote:
> On Thu, 15 Feb 2007 17:46:56 -0500
> Mathieu Desnoyers <[email protected]> wrote:
> 
> > > Me too.  It's due to the linux-kernel-markers patches.  Mathieu, can you
> > > take a look please?
> > 
> > I will give a deeper look in sparse, but I should say up front that I
> > add this to the root build tree Makefile :
> > 
> > LINUXINCLUDE    := -Iinclude \
> >                    $(if $(KBUILD_SRC),-Iinclude2 -I$(srctree)/include) \
> >                    -include include/linux/autoconf.h \
> >                    -include linux/marker.h
> > 
> > I guess sparse is maybe not using this Makefile or variable ?
> 
> ow, that's going to hurt - this stuff is complex and fragile.
> 

Sorry, I will remember to do more explicit changelogs.

> For what reason was that change made?
> 

It was made so that we can use the markers in C code without actually
including marker.h everywhere. I am sure someone has a better way to do
it : I would be happy to use this-nice-build-system-feature-I-missed to
have marker.h included.

> Pleeze, tricky things like this should be changelogged - we shouldn't need
> to ask.  I missed it.
> 
> 

-- 
Mathieu Desnoyers
Computer Engineering Ph.D. Candidate, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux