Re: [git patches] libata updates (mostly fixes)

On Thu, 15 Feb 2007, Jeff Garzik wrote:
> 
> diff --git a/arch/ia64/Kconfig b/arch/ia64/Kconfig
> index db185f3..d51f0f1 100644
> --- a/arch/ia64/Kconfig
> +++ b/arch/ia64/Kconfig
> @@ -22,6 +22,7 @@ config IA64
>  
>  config 64BIT
>  	bool
> +	select ATA_NONSTANDARD if ATA
>  	default y

Ok, this is just _strange_.

Tying ATA_NONSTANDARD into ia64 by tying it to the 64BIT config variable 
may work (well, I _assume_ it does), but it's just psychedelic.

How about adding a separate config entry like

	config IA64_ATA
		bool
		depends on ATA
		select ATA_NONSTANDARD
		default y

which kind of makes sense when you squint just the right way..

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [git patches] libata updates (mostly fixes)
    • From: Adrian Bunk <[email protected]>
  • Re: [git patches] libata updates (mostly fixes)
    • From: Jeff Garzik <[email protected]>
  • Re: [git patches] libata updates (mostly fixes)
    • From: Linus Torvalds <[email protected]>

• References:
  • [git patches] libata updates (mostly fixes)
    • From: Jeff Garzik <[email protected]>

• Prev by Date: Re: sparse chokes on arch/i386/kernel/i8253.c (was: 2.6.20-mm1)
• Next by Date: Re: [PATCH] No need to use -traditional for processing asm in i386/kernel/
• Previous by thread: Re: [PATCH] libata: test major version in ata_id_is_sata()
• Next by thread: Re: [git patches] libata updates (mostly fixes)
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]