Re: [PATCH x86 for review III] [1/29] i386: avoid gcc extension

Hi,

On 12/02/07, Andi Kleen <[email protected]> wrote:

setcc() in math-emu is written as a gcc extension statement expression
macro that returns a value.  However, it's not used that way and it's not
needed like that, so just make it a do-while non-extension macro so that we
don't use an extension when it's not needed.

This description ...

-#define setcc(cc) ({ \
-  partial_status &= ~(SW_C0|SW_C1|SW_C2|SW_C3); \
-  partial_status |= (cc) & (SW_C0|SW_C1|SW_C2|SW_C3); })
+static inline void setcc(int cc)
+{
+       partial_status &= ~(SW_C0|SW_C1|SW_C2|SW_C3);
+       partial_status |= (cc) & (SW_C0|SW_C1|SW_C2|SW_C3);
+}

... seems to contradict the implementation.  No "do-while" here.

I hope this helps,
Jochen
--
http://seehuhn.de/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH x86 for review III] [1/29] i386: avoid gcc extension
    • From: Randy Dunlap <[email protected]>

• References:
  • [PATCH x86 for review III] [1/29] i386: avoid gcc extension
    • From: Andi Kleen <[email protected]>

• Prev by Date: [PATCH] eCryptfs: Reduce stack usage in ecryptfs_generate_key_packet_set()
• Next by Date: Re: [PATCH x86 for review II] [34/39] i386: Use stack arguments for calling into EFI
• Previous by thread: Re: [PATCH x86 for review III] [12/29] x86_64: 32-bit ptrace mangles sixth system call argument
• Next by thread: Re: [PATCH x86 for review III] [1/29] i386: avoid gcc extension
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]