Re: [patch] linux/io.h: forward declare struct pci_dev

On Sun, Feb 11, 2007 at 07:10:47AM +0000, Christoph Hellwig wrote:
> On Sun, Feb 11, 2007 at 06:34:31AM +0000, Al Viro wrote:
> > +config NO_IOPORT
> > +	bool
> > +	default n
> 
> please make this IOPORT.  config symbols with an implicit negation
> are quite horrible for the brain to understand.

Take a look at lib/Kconfig.  And see HAS_IOPORT there.

The reason for doing it that way: majority of targets has that stuff
already.  Even more should have it eventually.  IOW, the default should
be positive.  Modified in arch/*/Kconfig of targets where it doesn't
work.  Which is exactly what's done here.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [patch] linux/io.h: forward declare struct pci_dev
    • From: Heiko Carstens <[email protected]>
  • Re: [patch] linux/io.h: forward declare struct pci_dev
    • From: Christoph Hellwig <[email protected]>
  • Re: [patch] linux/io.h: forward declare struct pci_dev
    • From: Tejun Heo <[email protected]>
  • Re: [patch] linux/io.h: forward declare struct pci_dev
    • From: Al Viro <[email protected]>
  • Re: [patch] linux/io.h: forward declare struct pci_dev
    • From: Christoph Hellwig <[email protected]>

• Prev by Date: [PATCH] pcmcia: some class_device fallout
• Next by Date: Re: Still cant boot 2.6.20
• Previous by thread: Re: [patch] linux/io.h: forward declare struct pci_dev
• Next by thread: Re: [patch] linux/io.h: forward declare struct pci_dev
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]