Re: + smaps-add-clear_refs-file-to-clear-reference.patch added to -mm tree

David Rientjes wrote:
>
> +static ssize_t clear_refs_write(struct file *file, const char __user *buf,
> +				size_t count, loff_t *ppos)
> +{
> ...
> +	task = get_proc_task(file->f_path.dentry->d_inode);
> +	if (!task)
> +		return -ESRCH;
> +	clear_refs_smap(task->mm->mmap);

task->mm may be NULL and not stable, this needs get_task_mm() (may fail).

Don't we also need ->mmap_sem to iterate vmas?

Oleg.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: + smaps-add-clear_refs-file-to-clear-reference.patch added to -mm tree
    • From: David Rientjes <[email protected]>
  • Re: + smaps-add-clear_refs-file-to-clear-reference.patch added to -mm tree
    • From: Andrew Morton <[email protected]>

• Prev by Date: Re: [PATCH] fbdev driver for S3 Trio/Virge, updated
• Next by Date: Re: [PATCH] fix quadratic behavior of shrink_dcache_parent()
• Previous by thread: Fix null pointer dereference in appledisplay driver
• Next by thread: Re: + smaps-add-clear_refs-file-to-clear-reference.patch added to -mm tree
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]