Re: [PATCH 2/2] Char: timers cleanup

Hi Jiri,

> timers cleanup
> 
> - Use timer macros to set function and data members and to modify
>   expiration time.
> - Use DEFINE_TIMER for global timers and do not init them at run-time in
>   these cases.
> - del_timer_sync is common in most cases -- we want to wait for timer
>   function if it's still running.

For the watchdog drivers: the timers are only used if the watchdog is active.
Why should we not init them at run time but use the DEFINE_TIMER macro?
Personnaly I prefer to use the same syntax in all the watchdog drivers
(thus either DEFINE_TIMER or either setup_timer() ).

Greetings,
Wim.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 1/2] Char: specialix, isr have 2 params
    • From: Jiri Slaby <[email protected]>
  • [PATCH 2/2] Char: timers cleanup
    • From: Jiri Slaby <[email protected]>

• Prev by Date: Re: [PATCH] pata_acpi: take two
• Next by Date: Re: [BUG?] ata disk running maximum at DMA33 with 2.6.20 and new pata driver, NV CK804 ide controller.
• Previous by thread: [PATCH 2/2] Char: timers cleanup
• Next by thread: [patch] i386/x86_64: smp_call_function locking inconsistency
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]