Re: [PATCH 4 of 7] lguest: Config and headers

On Sat, 10 Feb 2007, Rusty Russell wrote:

> +/* 64k ought to be enough for anybody! */
> +#define HYPERVISOR_MAP_ORDER 16
> +#define HYPERVISOR_PAGES ((1 << HYPERVISOR_MAP_ORDER)/PAGE_SIZE)

I think it'd be better to go back to defining HYPERVISOR_SIZE then derive 
the map order from that via get_order(), as it should be 4 instead of 16; 
and this code is now both implying PAGE_SIZE while also using it for 
calculations. 


- James
-- 
James Morris
<[email protected]>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 4 of 7] lguest: Config and headers
    • From: Rusty Russell <[email protected]>

• References:
  • [PATCH 0 of 7] lguest host code
    • From: Rusty Russell <[email protected]>
  • [PATCH 1 of 7] lguest: Move mce_disabled to asm/mce.h so lguest can use it.
    • From: Rusty Russell <[email protected]>
  • [PATCH 2 of 7] lguest: Rename cpu_gdt_descr and remove extern declaration from smpboot.c
    • From: Rusty Russell <[email protected]>
  • [PATCH 3 of 7] lguest: Remove extern declaration from mm/discontig.c, put in header.
    • From: Rusty Russell <[email protected]>
  • [PATCH 4 of 7] lguest: Config and headers
    • From: Rusty Russell <[email protected]>

• Prev by Date: [PATCH] fix misannotation of linkinfo_dn
• Next by Date: Re: [RFC][PATCH 6/6] automatic tuning applied to some kernel components
• Previous by thread: [PATCH 7 of 7] lguest: Makefile
• Next by thread: Re: [PATCH 4 of 7] lguest: Config and headers
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]