Re: [PATCH 6/10] lguest code: the little linux hypervisor.

On Fri, 09 Feb 2007 20:20:27 +1100 Rusty Russell <[email protected]> wrote:

> +#define log(...)					\
> +	do {						\
> +		mm_segment_t oldfs = get_fs();		\
> +		char buf[100];				\
> +		sprintf(buf, "lguest:" __VA_ARGS__);	\
> +		set_fs(KERNEL_DS);			\
> +		sys_write(1, buf, strlen(buf));		\
> +		set_fs(oldfs);				\
> +	} while(0)

Due to gcc shortcomings, each instance of this will chew an additional 100
bytes of stack.  Unless they fixed it recently.  Is a bit of a timebomb.  I
guess ksaprintf() could be used.

It also looks a bit, umm, innovative.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 6/10] lguest code: the little linux hypervisor.
    • From: Rusty Russell <[email protected]>

• References:
  • [PATCH 0/10] lguest
    • From: Rusty Russell <[email protected]>
  • [PATCH 1/10] lguest: Don't rely on last-linked fallthru when no paravirt handler
    • From: Rusty Russell <[email protected]>
  • [PATCH 4/10] lguest: Initialize esp0 properly all the time
    • From: Rusty Russell <[email protected]>
  • [PATCH 5/10] Make hvc_console.c compile on non-PowerPC
    • From: Rusty Russell <[email protected]>

• Prev by Date: Re: [PATCH] Convert pci_module_init() to pci_register_driver()
• Next by Date: [PATCH] [ipv6]: adjust inet6_exit() cleanup sequence against inet6_init()
• Previous by thread: [PATCH 10/10] lguest: documentatation including example launcher
• Next by thread: Re: [PATCH 6/10] lguest code: the little linux hypervisor.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]