[PATCH 5/28] driver core: Remove device_is_registered() in device_move().

From: Cornelia Huck <[email protected]>

device_is_registered() will always be false for a device with no bus. Remove
this check and trust the caller to know what they're doing.

Signed-off-by: Cornelia Huck <[email protected]>
Cc: Marcel Holtmann <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
---
 drivers/base/core.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/drivers/base/core.c b/drivers/base/core.c
index 67b79a7..36eedfd 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -1004,10 +1004,6 @@ int device_move(struct device *dev, struct device *new_parent)
 	if (!dev)
 		return -EINVAL;
 
-	if (!device_is_registered(dev)) {
-		error = -EINVAL;
-		goto out;
-	}
 	new_parent = get_device(new_parent);
 	if (!new_parent) {
 		error = -EINVAL;
-- 
1.4.4.4

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • [PATCH 6/28] driver core: Allow device_move(dev, NULL).
    • From: Greg KH <[email protected]>

• References:
  • [GIT PATCH] Driver core patches for 2.6.20
    • From: Greg KH <[email protected]>
  • [PATCH 1/28] Kobject: make kobject apis more robust in handling NULL pointers
    • From: Greg KH <[email protected]>
  • [PATCH 2/28] Driver core: convert pcmcia code to use struct device
    • From: Greg KH <[email protected]>
  • [PATCH 3/28] Driver core: convert SPI code to use struct device
    • From: Greg KH <[email protected]>
  • [PATCH 4/28] Network: convert network devices to use struct device instead of class_device
    • From: Greg KH <[email protected]>

• Prev by Date: [PATCH 6/28] driver core: Allow device_move(dev, NULL).
• Next by Date: [PATCH 4/28] Network: convert network devices to use struct device instead of class_device
• Previous by thread: [PATCH 4/28] Network: convert network devices to use struct device instead of class_device
• Next by thread: [PATCH 6/28] driver core: Allow device_move(dev, NULL).
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]