Stephen Hemminger wrote:
Turn flow control off for sky2. When flow control is on, the transmitter
may get randomly stuck. Perhaps there is hardware problem, but until
Marvell provides errata information for workaround, it should default to off.
Signed-off-by: Stephen Hemminger <[email protected]>
---
drivers/net/sky2.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/sky2.c b/drivers/net/sky2.c
index 822dd0b..a31dea5 100644
--- a/drivers/net/sky2.c
+++ b/drivers/net/sky2.c
@@ -3263,7 +3263,7 @@ #endif
/* Auto speed and flow control */
sky2->autoneg = AUTONEG_ENABLE;
- sky2->flow_mode = FC_BOTH;
+ sky2->flow_mode = FC_NONE;
I ACK the patch... conditional on some -mm style testing and user ACKs.
Logic: if there were no downsides to disabling flow control globally,
the world's networks would have already done so. Flow control can be
quite helpful, so I while I understand the errata argument, I also want
to understand the full effect of this tiny patch.
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
