Thank Alan. I made the changes yesterday but I'll wait another day
before reposting, in case other interested people have more comments.
Marc
Alan wrote:
> > unsigned char hub6; /* this should
> be in the 8250 driver */
> > unsigned char unused[3];
> > + void *data; /*
> generic platform data pointer */
> > };
>
> Convention is "private_data"
>
> >
> > /*
> > diff --git a/include/linux/serial_reg.h b/include/linux/serial_reg.h
> > index 3c8a6aa..b3550cc 100644
> > --- a/include/linux/serial_reg.h
> > +++ b/include/linux/serial_reg.h
> > @@ -37,6 +37,7 @@ #define UART_IIR_MSI 0x00 /* Modem stat
> > #define UART_IIR_THRI 0x02 /* Transmitter holding
> register empty */
> > #define UART_IIR_RDI 0x04 /* Receiver data interrupt */
> > #define UART_IIR_RLSI 0x06 /* Receiver line status
> interrupt */
> > +#define UART_IIR_BUSY 0x07 /* DesignWare APB Busy
> Detect */
>
> Please move this down a line to break it from "official" values and call
> it DESIGNWARE_UART_IIR_BUSY, so it is obviously designware specific.
>
> Otherwise looks much less invasive and messy
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
