On 02/06, S?bastien Dugu? wrote:
>
> @@ -970,8 +969,14 @@ static long aio_setup_sigevent(struct ai
> rcu_read_lock();
> target = sigevent_find_task(&event);
>
> - if (unlikely(!target))
> + if (unlikely(!target)) {
> + /*
> + * Revert notify to SIGEV_NONE so that really_put_req()
> + * knows that no ref has been taken on a task.
> + */
> + notify->notify = SIGEV_NONE;
> goto out_unlock;
> + }
Very minor nit, feel free to ignore.
Isn't it better to move "notify->* = event.*;" down, when we know that
target != NULL. Imho, a bit easier to follow. This way we don't need to
reset notify->notify = SIGEV_NONE.
aio_setup_sigevent() relies on the fact that ->notify = SIGEV_NONE on
entry anyway.
Oleg.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- [PATCH -mm][AIO] AIO completion signal notification small cleanup
- From: Sébastien Dugué <[email protected]>
- Re: [PATCH -mm][AIO] AIO completion signal notification fixes and cleanups
- From: Sébastien Dugué <[email protected]>
- [PATCH -mm][AIO] AIO completion signal notification small cleanup
- References:
- [PATCH -mm 0/7][AIO] - AIO completion signal notification v6
- From: Sébastien Dugué <[email protected]>
- [PATCH -mm 4/7][AIO] - Make good_sigevent() non-static
- From: Sébastien Dugué <[email protected]>
- Re: [PATCH -mm 4/7][AIO] - Make good_sigevent() non-static
- From: Oleg Nesterov <[email protected]>
- [PATCH -mm 4/7][AIO] Resend - Make good_sigevent() non-static
- From: Sébastien Dugué <[email protected]>
- Re: [PATCH -mm 4/7][AIO] Resend - Make good_sigevent() non-static
- From: Oleg Nesterov <[email protected]>
- [PATCH -mm][AIO] Fix AIO completion signal notification possible ref leak
- From: Sébastien Dugué <[email protected]>
- Re: [PATCH -mm][AIO] Fix AIO completion signal notification possible ref leak
- From: Oleg Nesterov <[email protected]>
- [PATCH -mm][AIO] AIO completion signal notification fixes and cleanups
- From: Sébastien Dugué <[email protected]>
- [PATCH -mm 0/7][AIO] - AIO completion signal notification v6
- Prev by Date: Re: [discuss] [patch] mtrr: fix issues with large addresses
- Next by Date: Re: [PATCH] move remove_dquot_ref to dqout.c
- Previous by thread: [PATCH -mm][AIO] AIO completion signal notification fixes and cleanups
- Next by thread: Re: [PATCH -mm][AIO] AIO completion signal notification fixes and cleanups
- Index(es):
 |