Re: [PATCH 2.6.20] ibm_emac: Use ARRAY_SIZE macro when appropriate

On Mon, Feb 05, 2007 at 11:22:06PM +0300, Alexey Dobriyan wrote:
> On Mon, Feb 05, 2007 at 06:59:16PM +0200, Ahmed S. Darwish wrote:
> > A patch to use ARRAY_SIZE macro already defined in kernel.h.
> 
> OK, but checks you're changing are strange. idx there is signed so
> 
> 	BUG_ON(idx < 0 || idx > ARRAY_SIZE());
> 
> should be more appropriate.

It's just a janitor patch. I don't like to mess with code logic in such
kind of patches (to minimize errors and because I can't find time to
understand all affected files since they are scattered allover the tree).

Thanks,
-- 
Ahmed S. Darwish
http://darwish-07.blogspot.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 00] A series of patches to use ARRAY_SIZE in `net' drivers
    • From: "Ahmed S. Darwish" <[email protected]>
  • [PATCH 2.6.20] ibm_emac: Use ARRAY_SIZE macro when appropriate
    • From: "Ahmed S. Darwish" <[email protected]>
  • Re: [PATCH 2.6.20] ibm_emac: Use ARRAY_SIZE macro when appropriate
    • From: Alexey Dobriyan <[email protected]>

• Prev by Date: Re: 2.6.19.2, 2.6.20 Kernel oops
• Next by Date: Re: [PATCH][0/5] floppy.c: first round of cleanup patches - the simple stuff
• Previous by thread: Re: [PATCH 2.6.20] ibm_emac: Use ARRAY_SIZE macro when appropriate
• Next by thread: [PATCH 2.6.20] ixgb: Use ARRAY_SIZE macro when appropriate
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]