Re: [PATCH] Missing critical phys_to_virt in lib/swiotlb.c

I wrote:
> Unfortunately an author of lib/swiotlb.c chose to call many variables
> holding *virtual* addresses "dma_addr". Note how that file at the same
> time contains variables like "dma_addr_t dma_handle".

And there is even one occurrence of a "dma_addr" holding a physical
address/ bus address, unlike the other dma_addr's:
int
swiotlb_dma_mapping_error(dma_addr_t dma_addr)
{
	return (dma_addr == virt_to_phys(io_tlb_overflow_buffer));
}
-- 
Stefan Richter
-=====-=-=== --=- --==-
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] Missing critical phys_to_virt in lib/swiotlb.c
    • From: David Moore <[email protected]>
  • Re: [PATCH] Missing critical phys_to_virt in lib/swiotlb.c
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH] Missing critical phys_to_virt in lib/swiotlb.c
    • From: Andi Kleen <[email protected]>
  • Re: [PATCH] Missing critical phys_to_virt in lib/swiotlb.c
    • From: Stefan Richter <[email protected]>

• Prev by Date: Re: [PATCH 0/11] VMI / Paravirt bugfixes for 2.6.21
• Next by Date: Re: 2.6.19.2, 2.6.20 Kernel oops
• Previous by thread: Re: [PATCH] Missing critical phys_to_virt in lib/swiotlb.c
• Next by thread: Re: [PATCH] Missing critical phys_to_virt in lib/swiotlb.c
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]