Re: [PATCH 2.6.20] ixgb: Use ARRAY_SIZE macro when appropriate

Alexey Dobriyan wrote:

On Mon, Feb 05, 2007 at 06:59:33PM +0200, Ahmed S. Darwish wrote:

A patch to use ARRAY_SIZE macro already defined in kernel.h.

Remove it and use ARRAY_SIZE instead.

--- a/drivers/net/ixgb/ixgb_param.c
+++ b/drivers/net/ixgb/ixgb_param.c
@@ -245,7 +245,7 @@ ixgb_validate_option(int *value, struct ixgb_option *opt)
 	return -1;
 }

-#define LIST_LEN(l) (sizeof(l) / sizeof(l[0]))

+#define LIST_LEN(l) ARRAY_SIZE(l)

yes, well spotted. Please change line 338 in this file to read:

     .arg  = { .l = { .nr = ARRAY_SIZE(fc_list),

instead, so you can remove the LIST_LEN macro completely.

Thanks,

Auke
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 2.6.20] ixgb: Use ARRAY_SIZE macro when appropriate
    • From: "Ahmed S. Darwish" <[email protected]>

• References:
  • [PATCH 00] A series of patches to use ARRAY_SIZE in `net' drivers
    • From: "Ahmed S. Darwish" <[email protected]>
  • [PATCH 2.6.20] ixgb: Use ARRAY_SIZE macro when appropriate
    • From: "Ahmed S. Darwish" <[email protected]>
  • Re: [PATCH 2.6.20] ixgb: Use ARRAY_SIZE macro when appropriate
    • From: Alexey Dobriyan <[email protected]>

• Prev by Date: Re: [PATCH] SUN3/3X Lance trivial fix
• Next by Date: Re: [PATCH 2/2] Char: use more PCI_DEVICE macro
• Previous by thread: Re: [PATCH 2.6.20] ixgb: Use ARRAY_SIZE macro when appropriate
• Next by thread: Re: [PATCH 2.6.20] ixgb: Use ARRAY_SIZE macro when appropriate
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]