Re: [PATCH] ipv4: remove a call to skb_queue_len() in inet_diag.c

From: Thomas Hisch <[email protected]>
Date: Sun, 4 Feb 2007 15:29:21 +0100

> remove unneeded call to skb_queue_len (skb_dequeue already checks queuelen) and
> replace a sizeof() by a Netlink Macro
> 
> Signed-off-by: Thomas Hisch <[email protected]>

You don't understand the code you are editing :-)

We want to process the number of packets present when we
start the function, other threads can add more packets to
the queue meanwhile and we don't want to keep dequeueing
in that case or else we can theoretically run forever with
a fast enough producer.

Also, please post all networking patches to [email protected],
the majority of the networking developers do not read linux-kernel.

Thank you.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] ipv4: remove a call to skb_queue_len() in inet_diag.c
    • From: Thomas Hisch <[email protected]>

• Prev by Date: Re: More pata_ stuff
• Next by Date: Re: Timeouts on ICH7 PATA drive with ata_piix; ide_generic worksperfectly
• Previous by thread: [PATCH] ipv4: remove a call to skb_queue_len() in inet_diag.c
• Next by thread: [PATCH] ipv4: remove a call to skb_queue_len() in inet_diag.c
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]