Andrew Morton wrote:
On Fri, 02 Feb 2007 13:50:10 -1000
[email protected] wrote:
<snipped>
+struct suspremount {
+struct super_block *sb;
+struct suspremount *next;
+};
The fields of this struct need a leading tab.
ok.
The name "suspremount" might be unpopular. suspend_remount_state would be
more kernely.
ok.
+static struct suspremount *suspremount_list;
+
+void suspend_remount_log_fs(struct super_block *sb)
+{
+ struct suspremount *remountp;
+
+ if ((remountp = (struct suspremount *)
+ kmalloc(sizeof(struct suspremount), GFP_KERNEL)) != NULL) {
The typecast is unneeded, and the compounded assign-and-test is not
preferred style. So here, please use
struct suspremount *remountp;
remountp = kmalloc(sizeof(*remountp), GFP_KERNEL);
if (remountp != NULL) {
ok.
+EXPORT_SYMBOL(suspend_remount_all_fs_ro);
Why is this exported to modules?
it shouldn't. will remove
+ sb = remountp->sb;
+ flags = 0;
+ if (sb->s_op && sb->s_op->remount_fs) {
+ ret = sb->s_op->remount_fs(sb, &flags, NULL);
+ if (ret) printk("resume_remount_rw: error %d\n", ret);
newline needed here.
ok.
super_block_operations.remount_fs() is supposed to be called under lock_super().
Some filesystems might go BUG over this, or something. Was there a reason to
not do this?
nope. will correct
+ }
+
+ tp = remountp->next;
+ kfree(remountp);
+ remountp = tp;
+ }
+ suspremount_list = NULL;
+}
+EXPORT_SYMBOL(resume_remount_fs_rw);
Why the export?
shouldn't
All this code is singly-threaded at a much higher level (I hope), hence
that list doesn't need locking. However a comment explaining this might be
good.
ok.
@@ -613,6 +677,9 @@ int do_remount_sb(struct super_block *sb
unlock_super(sb);
if (retval)
return retval;
+#ifdef CONFIG_SUSPEND_REMOUNTFS
+ suspend_remount_log_fs(sb);
+#endif
We try to avoid putting ifdefs in C files. So in a header file, do
struct super_block;
#ifdef CONFIG_SUSPEND_REMOUNTFS
extern void suspend_remount_log_fs(struct super_block *sb);
#else
static inline void suspend_remount_log_fs(struct super_block *sb) {}
#endif
will do.
Many thanks on the feedback.
Armin
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
