Re: Should io(read|write)(8|16|32)_rep take (const|) volatile u(8|16|32) __iomem *addr?

H. Peter Anvin wrote:

Jeff Garzik wrote:

Volatile is usually reserved for a specific need on a specific arch. I doubt it is correct to force it on all arches.

They already are volatile; the issue is adding "const".

All io(read|write)* pointers are volatile, IIRC.

No, none are volatile, hence my comment.

[jgarzik@pretzel linux-2.6]$ grep volatile lib/iomap.c include/asm-generic/iomap.h [jgarzik@pretzel linux-2.6]$

Maybe you were thinking about writel() and friends, whose implementation (not prototype!) includes use of volatile.

Regards,

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: Should io(read|write)(8|16|32)_rep take (const|) volatile u(8|16|32) __iomem *addr?
    • From: "Michael K. Edwards" <[email protected]>

• References:
  • Should io(read|write)(8|16|32)_rep take (const|) volatile u(8|16|32) __iomem *addr?
    • From: "Michael K. Edwards" <[email protected]>
  • Re: Should io(read|write)(8|16|32)_rep take (const|) volatile u(8|16|32) __iomem *addr?
    • From: Jeff Garzik <[email protected]>
  • Re: Should io(read|write)(8|16|32)_rep take (const|) volatile u(8|16|32) __iomem *addr?
    • From: "H. Peter Anvin" <[email protected]>

• Prev by Date: Re: sky2 hangs
• Next by Date: Re: smp and irq conflict
• Previous by thread: Re: Should io(read|write)(8|16|32)_rep take (const|) volatile u(8|16|32) __iomem *addr?
• Next by thread: Re: Should io(read|write)(8|16|32)_rep take (const|) volatile u(8|16|32) __iomem *addr?
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]