Hi,
the following series of 10 trivial patches contains two changes:
- removes local_irq_disable() on redundant places after local_irq_save()
- turns local_save_flags() + local_irq_disable() into local_irq_save()
It was quite surprising to find it on so many places. There is another gem
in drivers/block/ataflop.c::do_fd_request():
local_save_flags(flags); /* The request function is called with ints
local_irq_disable(); * disabled... so must save the IPL for later */
I am not sure if the author was aware of the fact that he commented also
the local_irq_disable() call :) I will look into the code a bit more
later, to see whether it just really wants to save flags, or this should
be converted into standard local_irq_save(flags).
--
Jiri Kosina
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- [PATCH 6/10] CHAR-Amiserial: turn local_save_flags() + local_irq_disable() into local_irq_save()
- From: Jiri Kosina <[email protected]>
- [PATCH 10/10] CRIS: turn local_save_flags() + local_irq_disable() into local_irq_save()
- From: Jiri Kosina <[email protected]>
- [PATCH 9/10] CRIS: turn local_save_flags() + local_irq_disable() into local_irq_save() in headers
- From: Jiri Kosina <[email protected]>
- [PATCH 7/10] CHAR-Amiserial: turn local_save_flags() + local_irq_disable() into local_irq_save()
- From: Jiri Kosina <[email protected]>
- [PATCH 8/10] NET-3c59x: turn local_save_flags() + local_irq_disable() into local_irq_save()
- From: Jiri Kosina <[email protected]>
- [PATCH 5/10] SCSI-BusLogic: local_irq_disable() is redundant after local_irq_save()
- From: Jiri Kosina <[email protected]>
- [PATCH 3/10] POWERPC-86xx: local_irq_disable() is redundant after local_irq_save()
- From: Jiri Kosina <[email protected]>
- [PATCH 4/10] POWERPC-Powermac: local_irq_disable() is redundant after local_irq_save()
- From: Jiri Kosina <[email protected]>
- [PATCH 2/10] X86_64: local_irq_disable() is redundant after local_irq_save()
- From: Jiri Kosina <[email protected]>
- [PATCH 1/10] CRIS: local_irq_disable() is redundant after local_irq_save()
- From: Jiri Kosina <[email protected]>
- [PATCH 6/10] CHAR-Amiserial: turn local_save_flags() + local_irq_disable() into local_irq_save()
- Prev by Date: Re: 2.6.16.16 Lost CD-ROM Drive
- Next by Date: [PATCH 1/10] CRIS: local_irq_disable() is redundant after local_irq_save()
- Previous by thread: Re: [patch, rfc] kbuild: implement checksrc without building Cources...
- Next by thread: [PATCH 1/10] CRIS: local_irq_disable() is redundant after local_irq_save()
- Index(es):
 |