On Thu, Feb 01, 2007 at 12:28:50PM +0100, Andi Kleen wrote:
> On Thursday 01 February 2007 11:00, [email protected] wrote:
> > +inline u64 mt_to_nsec(u64 mt)
> > +{
> > + u64 ret;
> > + ret = ((mt & 0xffffff) * vxtime.mt_q) >> 32;
> > + mt >>= 24;
> > + ret += ((mt & 0xffffff) * vxtime.mt_q) >> 8;
> > + mt >>= 24;
> > + ret += ( mt * vxtime.mt_q) << 16;
> > + return ret;
>
> Why so complicated? Isn't a single multiply good enough?
This does a multiplication and a downshift at once. The problem
is, that if we first do the multipclication, the result won't fit
in 64 bits.
If we first do the downshift, we lose precision.
This does both operations at once, avoiding both the overflow and
underflow.
--
Jiri Bohac <[email protected]>
SUSE Labs, SUSE CZ
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
