Re: [patch 6/9] Add the "Master Timer"

On Thu, Feb 01, 2007 at 12:22:55PM +0100, Andi Kleen wrote:
> >  
> > -unsigned int cpu_khz;					/* TSC clocks / usec, not used here */
> > +unsigned int cpu_khz;		/* TSC clocks / usec, not used here */
> > +static s64 mt_per_tick;		/* master timer ticks per jiffie */
> > +static u64 __mt;		/* master timer */
> > +static u32 __mt_last;		/* value last read from read_master_timer() when updating timer caches */
> 
> Why the underscores? 

To make it clear that the variables should not be used directly.
They should only be accessed through the get_master_timer(),
set_master_timer64(), etc. funcitions.

Something wrong with that? I have no problem deleting the
underscores :-)

-- 
Jiri Bohac <[email protected]>
SUSE Labs, SUSE CZ

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [patch 0/9] x86_64: reliable TSC-based gettimeofday
    • From: [email protected]
  • [patch 6/9] Add the "Master Timer"
    • From: [email protected]
  • Re: [patch 6/9] Add the "Master Timer"
    • From: Andi Kleen <[email protected]>

• Prev by Date: Re: Rewriting floppy.c was Re: Free Linux Driver Development!
• Next by Date: [PATCH] SCSI: Fix obvious typo "spin_lock_irqrestore()" in gdth.c.
• Previous by thread: Re: [patch 6/9] Add the "Master Timer"
• Next by thread: [patch 8/9] Add time_update_mt_guess()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]