Re: [patch 7/9] Adapt the time initialization code

> +extern void time_initialize_cpu(void);

Never put externs into .c files. Multiple occurrences.


> +void time_initialize_cpu(void *info)
> +{
> +	unsigned long flags;
> +	int cpu = smp_processor_id();

Are you sure this can never preempt? 

> +	/* FIXME: what speed does the cpu really start at; I doubt cpu_khz is right at this point ??!!!

It should be. It comes from measurements. Unless the CPU changes frequency
behind the kernel's back, but there is nothing that can be done then.

-Andio
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [patch 7/9] Adapt the time initialization code
    • From: Jiri Bohac <[email protected]>

• References:
  • [patch 0/9] x86_64: reliable TSC-based gettimeofday
    • From: [email protected]
  • [patch 7/9] Adapt the time initialization code
    • From: [email protected]

• Prev by Date: Re: [patch 6/9] Add the "Master Timer"
• Next by Date: Re: [patch 9/9] Make use of the Master Timer
• Previous by thread: [patch 7/9] Adapt the time initialization code
• Next by thread: Re: [patch 7/9] Adapt the time initialization code
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]