Re: [PATCH 8/10] cxgb3 - Unmap offload packets when they are freed.

Divy Le Ray wrote:

From: Divy Le Ray <[email protected]>

Offload packets may be DMAed long after their SGE Tx descriptors are done
so they must remain mapped until they are freed rather than until their
descriptors are freed.  Unmap such packets through an skb destructor.

Signed-off-by: Divy Le Ray <[email protected]>

this is questionable and sounds like you are working around a bug. I can't think of another driver that uses skb destructors, and I could have sworn that skb destructors were not for drivers to use anyway

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 8/10] cxgb3 - Unmap offload packets when they are freed.
    • From: Divy Le Ray <[email protected]>

• References:
  • [PATCH 8/10] cxgb3 - Unmap offload packets when they are freed.
    • From: Divy Le Ray <[email protected]>

• Prev by Date: Re: [PATCH 1/10] cxgb3 - FW versioning
• Next by Date: Re: [PATCH 1/10] cxgb3 - FW versioning
• Previous by thread: [PATCH 8/10] cxgb3 - Unmap offload packets when they are freed.
• Next by thread: Re: [PATCH 8/10] cxgb3 - Unmap offload packets when they are freed.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]