Re: [PATCH] tty: cleanup release_mem

On Sun, Jan 28, 2007 at 06:12:44PM +0100, Christoph Hellwig wrote:
> release_mem contains two copies of exactly the same code.  Refactor
> these into a new helper, release_tty.  The only change in behaviour
> is that the driver reference count is now decremented after the
> master tty has been freed instead of before.
> 
> 
> Signed-off-by: Christoph Hellwig <[email protected]>

Acked-by: Alan Cox <[email protected]>

Please propogate the mutex_ FIXME comment to both functions as it may
well need to cover tty->link

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] tty: cleanup release_mem
    • From: Christoph Hellwig <[email protected]>

• References:
  • [PATCH] tty: cleanup release_mem
    • From: Christoph Hellwig <[email protected]>

• Prev by Date: Problem with unix sockets: SOCK_DGRAM ignores MSG_TRUNC
• Next by Date: [PATCH -mm] sn2: use static ->proc_fops
• Previous by thread: [PATCH] tty: cleanup release_mem
• Next by thread: Re: [PATCH] tty: cleanup release_mem
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]