On Mon, 29 Jan 2007, Jiri Kosina wrote:
> Ah, now I see. The problem is that in pre-2.6.20-rc1 the pb_fnmode was
> setting global variable, but after the HID layer rework, this is a
> per-hid variable, which is of course not updated when write to sysfs
> triggers. I will try to fix this before I send 2.6.20-rc6 updates to
> Linus, thanks for pointing this out.
Actually the cleanest solution would be when I change the code in such a
way that pb_fnmode parameter would be passed to hid instead of usbhid
module, as this is where the input mapping is being done (you could
potentially have a keyboard which needs the very same handling of fn mode
as usb powerbook keyboards currently have, but on different transport
- input mapping is logically transport independent).
But I guess you will be not OK with breaking the backward compatibility in
such way, because all the already existing tutorials, etc. right?
Would warning that would trigger when the module parameter is passed to
usbhid and would instruct user to pass the parameter to hid module
instead, be acceptable? (and then changing the parameter of hid module
through sysfs would work as expected again).
Thanks,
--
Jiri Kosina
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
