Paul Mackerras <[email protected]> writes:
> Eric W. Biederman writes:
>
>> @@ -693,15 +664,14 @@ int pci_enable_msi(struct pci_dev* dev)
>> if (!pos)
>> return -EINVAL;
>>
>> - WARN_ON(!msi_lookup_irq(dev, PCI_CAP_ID_MSI));
>> + WARN_ON(!!dev->msi_enabled);
>
> Minor nit: what's wrong with just WARN_ON(dev->msi_enabled) ?
It's a bitfield so gcc complains when something in WARN_ON calls
typeof on it. So it is easier to just say !! than to dig into
WARN_ON and see if it made any sense to fix WARN_ON, or to see if gcc
needed the bug fix.
> Also here:
>
>> @@ -836,16 +811,14 @@ int pci_enable_msix(struct pci_dev* dev, struct
> msix_entry *entries, int nvec)
>> return -EINVAL; /* duplicate entry */
>> }
>> }
>> - temp = dev->irq;
>> - WARN_ON(!msi_lookup_irq(dev, PCI_CAP_ID_MSIX));
>> + WARN_ON(!!dev->msix_enabled);
>
> Paul.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
