Re: [PATCH] libata-sff: Don't call bmdma_stop on non DMA capable controllers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Alan wrote:
Fixes bogus accesses to ports 0-15 with a non DMA capable controller.
This I think should go in for 2.6.20

applied to #upstream-fixes, but it's a hack based on a misunderstanding. See comments below for further work needed.


Arguably it shouldn't be called for PIO commands at all but thats a
matter for Jeff to decide

You are getting misled by the function name.

ata_bmdma_post_internal_cmd() is the common ->post_internal_cmd() hook for BMDMA-like (SFF-like) controllers. ->post_internal_cmd() hook will always be called, for all commands, when present.

For PIO-only controllers, simply delete the post_internal_cmd hook from that specific driver's ata_port_operations. (assuming no other cleanup is needed)

For other SFF controllers, perhaps ata_bmdma_post_internal_cmd() should be revised to check the taskfile protocol (PIO, DMA, ...)?

I leave that up to your judgement, to figure out what's best. I certainly AGREE that an unconditional ata_bmdma_stop() for all commands, for all taskfile protocols, sounds wrong.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux