Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks

I'm working on this now and will doublecheck just in case my test was
flawed first time.

Doublechecking indicates my initial test was wrong somehow; both
card->dev->parent and card->parent passed as arg 2 to the
device_create call in snd_register_device result in correct device
symlinks. Are these two actually semantically different?  I'm just
curious.

The call to device_create in cound_core.c:sound_insert_unit also needs
to be modified in order for the device symlinks in the other unit
types to be correct.  Again, modifying the 'dev' argument to
'(dev?dev->parent:NULL)' appears to fix the problem.  Is that
correct/appropriate there?

Monty
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks
    • From: "Christopher \"Monty\" Montgomery" <[email protected]>
  • Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks
    • From: Takashi Iwai <[email protected]>

• References:
  • [PATCH] alsa: correct nonsensical sysfs device symlinks
    • From: "Christopher \"Monty\" Montgomery" <[email protected]>
  • Re: [PATCH] alsa: correct nonsensical sysfs device symlinks
    • From: Greg KH <[email protected]>
  • Re: [PATCH] alsa: correct nonsensical sysfs device symlinks
    • From: "Christopher \"Monty\" Montgomery" <[email protected]>
  • Re: [PATCH] alsa: correct nonsensical sysfs device symlinks
    • From: Pierre Ossman <[email protected]>
  • Re: [PATCH] alsa: correct nonsensical sysfs device symlinks
    • From: "Christopher \"Monty\" Montgomery" <[email protected]>
  • Re: [PATCH] alsa: correct nonsensical sysfs device symlinks
    • From: Pierre Ossman <[email protected]>
  • Re: [PATCH] alsa: correct nonsensical sysfs device symlinks
    • From: "Christopher \"Monty\" Montgomery" <[email protected]>
  • Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks
    • From: Takashi Iwai <[email protected]>
  • Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks
    • From: "Christopher \"Monty\" Montgomery" <[email protected]>

• Prev by Date: Re: [PATCH] libata-sff: Don't call bmdma_stop on non DMA capable controllers
• Next by Date: Re: [PATCH] namespaces: fix race at task exit
• Previous by thread: Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks
• Next by thread: Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]