Here it is
On Thu, 25 Jan 2007 05:42:42 +0000 Christoph Hellwig <[email protected]> wrote:
> On Wed, Jan 24, 2007 at 12:11:30PM +0100, S?bastien Dugu? wrote:
> > > > + if (unlikely(!notify->sigq))
> > > > + return -EAGAIN;
> > >
> > > Did this just leak a ref on the task_struct?
> > >
> >
> > No, the ref is released in really_put_req() when we dispose of
> > the iocb.
>
> And the code really needs a comment explaining this. I tripped over
> this before, and I think it's even already the second time Andrew
> stumbled over it.
>
From: Sébastien Dugué <[email protected]>
Add a comment explaining why there is no task ref leak in
aio_setup_sigevent().
aio.c | 5 +++++
1 file changed, 5 insertions(+)
Signed-off-by: Sébastien Dugué <[email protected]>
Index: linux-2.6.20-rc4-mm1/fs/aio.c
===================================================================
--- linux-2.6.20-rc4-mm1.orig/fs/aio.c 2007-01-17 08:59:16.000000000 +0100
+++ linux-2.6.20-rc4-mm1/fs/aio.c 2007-01-25 09:52:29.000000000 +0100
@@ -987,6 +987,11 @@ static long aio_setup_sigevent(struct ai
*/
notify->sigq = sigqueue_alloc();
+ /*
+ * The task ref will be released in really_put_req()
+ * when we dispose of the iocb later on in the submission
+ * path.
+ */
if (unlikely(!notify->sigq))
return -EAGAIN;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
