Re: [PATCH -mm 4/5][AIO] - AIO completion signal notification

On Wed, Jan 24, 2007 at 12:11:30PM +0100, S?bastien Dugu? wrote:
> > > +	if (unlikely(!notify->sigq))
> > > +		return -EAGAIN;
> > 
> > Did this just leak a ref on the task_struct?
> > 
> 
>   No, the ref is released in really_put_req() when we dispose of
> the iocb.

And the code really needs a comment explaining this.  I tripped over
this before, and I think it's even already the second time Andrew
stumbled over it.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH -mm 4/5][AIO] - AIO completion signal notification
    • From: Sébastien Dugué <[email protected]>

• References:
  • [PATCH -mm 4/5][AIO] - AIO completion signal notification
    • From: Sébastien Dugué <[email protected]>
  • Re: [PATCH -mm 4/5][AIO] - AIO completion signal notification
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH -mm 4/5][AIO] - AIO completion signal notification
    • From: Sébastien Dugué <[email protected]>

• Prev by Date: 2.6.20-rc4 gfs2 bug
• Next by Date: Re: [RFC] Limit the size of the pagecache
• Previous by thread: Re: [PATCH -mm 4/5][AIO] - AIO completion signal notification
• Next by thread: Re: [PATCH -mm 4/5][AIO] - AIO completion signal notification
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]