Re: [2.6 patch] SCSI seagate.c: remove SEAGATE_USE_ASM

On Sun, 21 Jan 2007 20:13:00 +0100
Adrian Bunk <[email protected]> wrote:

> Using assembler code for performance in drivers might have been a good 
> idea 15 years ago when this code was written, but with today's compilers 
> that's unlikely to be an advantage.
> 
> Besides this, it also hurts the readability.
> 
> Simply use the C code that was already there as an alternative.
> 
> Signed-off-by: Adrian Bunk <[email protected]>
					"stosb\n\t"

NAK

The C codepaths are essentially untested on this driver.

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [2.6 patch] SCSI seagate.c: remove SEAGATE_USE_ASM
    • From: Adrian Bunk <[email protected]>

• References:
  • [2.6 patch] SCSI seagate.c: remove SEAGATE_USE_ASM
    • From: Adrian Bunk <[email protected]>

• Prev by Date: Re: [RFC 1/6] bidi support: request dma_data_direction
• Next by Date: Re: change strip_cache_size freeze the whole raid
• Previous by thread: [2.6 patch] SCSI seagate.c: remove SEAGATE_USE_ASM
• Next by thread: Re: [2.6 patch] SCSI seagate.c: remove SEAGATE_USE_ASM
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]