Re: [PATCH] include linux/fs.h in linux/cdev.h for struct inode

>Subject: [PATCH] include linux/fs.h in linux/cdev.h for struct inode

NAK.

Better is this:

Add missing struct predeclarations, otherwise we may get

x.c:2: warning: ‘struct inode’ declared inside parameter list
x.c:2: warning: its scope is only this definition or declaration, which is
probably not what you want

Signed-off-by: Jan Engelhardt <[email protected]>

Index: linux-2.6.20-rc5/include/linux/cdev.h
===================================================================
--- linux-2.6.20-rc5.orig/include/linux/cdev.h
+++ linux-2.6.20-rc5/include/linux/cdev.h
@@ -6,6 +6,10 @@
 #include <linux/kdev_t.h>
 #include <linux/list.h>
 
+struct file_operations;
+struct inode;
+struct module;
+
 struct cdev {
 	struct kobject kobj;
 	struct module *owner;

---

• References:
  • [PATCH] include linux/fs.h in linux/cdev.h for struct inode
    • From: Noah Watkins <[email protected]>

• Prev by Date: Re: [ANNOUNCE] System Inactivity Monitor v1.0
• Next by Date: Re: [ANNOUNCE] System Inactivity Monitor v1.0
• Previous by thread: Re: [PATCH] include linux/fs.h in linux/cdev.h for struct inode
• Next by thread: Probably wrong place to ask
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]